Pin Python dependencies and install them in a virtualenv #7404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! @damz thanks so much for looking into this. Now I'm sure I would have never fixed it 😅 |
Installing `sphinx` started to fail about a week ago, with `pip` incorrectly trying to remove a Python package shipped at the system level in Platform.sh environment. It looks like it started failing because of a bug in the older version of `pip` that ships with Debian Jessie. We (Platform.sh) install global Python dependencies as user-site packages (using `pip --user`). We also ship system-site packages that we use for our own benefit. So two issues here: * First, that older version of `pip`. We are going to look into upgrading it (a new batch of images based on Debian Stretch are cooking); * The build dependencies of the Symfony Docs are not pinned, which makes the build non-repeatable. I'm guessing that in this case it broke [when jinja2 ended up requiring markupsafe>=0.23][jinja2-commit] (but that's just a guess). Fix the issue for good by installing in a `virtualenv` and pinning all the dependencies via `pip freeze`. [jinja2-commit]: pallets/jinja@5453db1
|
You can pick either this one or #7403, and it is purely a "pick your poison" question:
|
damz
force-pushed
the
pr/pin-dependencies
branch
from
23f79c3 to
c025812
Compare
|
Thank you so much for fixing our platform.sh builds @damz! Happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Alternative version from #7403)
Installing
sphinxstarted to fail about a week ago, withpipincorrectly trying to remove a Python package shipped at the system level in Platform.sh environment.It looks like it started failing because of a bug in the older version of
pipthat ships with Debian Jessie. We (Platform.sh) install global Python dependencies as user-site packages (usingpip --user). We also ship system-site packages that we use for our own benefit.So two issues here:
pip. We are going to look into upgrading it (a new batch of images based on Debian Stretch are cooking);Fix the issue for good by installing in a
virtualenvand pinning all the dependencies viapip freeze.